cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pdube <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9235: Autoscale button is miss...
Date Tue, 19 Jan 2016 00:24:24 GMT
Github user pdube commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1337#discussion_r50060205
  
    --- Diff: ui/scripts/network.js ---
    @@ -3667,8 +3652,16 @@
                                                                 return 2; //hide Autoscale
button (both header and form)
                                                             }
                                                         } else { //from VPC section
    -                                                        //VPC doesn't support autoscale
    -                                                        return 2;
    +                                                        var lbProviderIsNetscaler;
    +                                                        var services = args.context.vpc[0].service;
    +
    +                                                        lbProviderIsNetscaler = checkIfNetScalerProviderIsEnabled(services);
    +
    +                                                        if (lbProviderIsNetscaler ==
true) { //AutoScale is only supported on Netscaler (but not on any other provider like VirtualRouter)
    --- End diff --
    
    You could remove the condition here, it is unnecessary


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message