cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bheuvel <...@git.apache.org>
Subject [GitHub] cloudstack pull request: test: Fix Libvirt test so that it works o...
Date Mon, 18 Jan 2016 18:02:10 GMT
Github user bheuvel commented on the pull request:

    https://github.com/apache/cloudstack/pull/1242#issuecomment-172607827
  
    Well, short answer, LGTM and seen it compile on Windows (only) with this adjustment.
    
    Longs answer has more to do with the object/code generating the path `/root/.ssh\id_rsa.pub.cloud`;
why mixing path separators like this, how is it made to work on Windows, is the respective
code supposed to run on windows at all, why hardcode path to `/root`-home and then some :smile:



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message