cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cristofolini <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9231: Root volume migration fr...
Date Sun, 17 Jan 2016 15:01:05 GMT
Github user cristofolini commented on the pull request:

    https://github.com/apache/cloudstack/pull/1336#issuecomment-172333464
  
    Fix looks simple enough. Code LGTM. Although I would usually suggest adding a javadoc
the new `MigrateWithStorageCommand` method you've created, this just changes the existing
method (which looks clear enough to me already) to use Lists instead of maps, so I'll leave
that decision up to you @nitin-maharana.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message