cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cristofolini <...@git.apache.org>
Subject [GitHub] cloudstack pull request: SecurityGroupRulesCmd code cleanup
Date Sat, 16 Jan 2016 17:32:48 GMT
Github user cristofolini commented on the pull request:

    https://github.com/apache/cloudstack/pull/1287#issuecomment-172234191
  
    @rafaelweingartner @DaanHoogland,
    Personally, I don't see a problem using final declarations for those attributes. They
all do seem to contain information that shouldn't be changed once instantiated.
    
    Other than that observation I feel comfortable agreeing with all of @rafaelweingartner's
suggestions. And besides adding a few more javadocs to the new methods and cleaning up the
existing ones, I don't see anything lacking here. As the new release approaches, it would
be fine to add these things at a later date.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message