cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pedro-martins <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8959: Option to attach the con...
Date Fri, 15 Jan 2016 21:46:26 GMT
Github user pedro-martins commented on the pull request:

    https://github.com/apache/cloudstack/pull/938#issuecomment-172103324
  
    Hi.
    There is no problem to set vmData to null?  and what about replace this short if to a
method with documentation and a little test.
    And if you extract all that you do to little methods, it will be easier to create test
cases and confirm that you do works correctly
    
    Ty =) .


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message