cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GabrielBrascher <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9198: Virtual router gets depl...
Date Wed, 13 Jan 2016 13:06:14 GMT
Github user GabrielBrascher commented on the pull request:

    https://github.com/apache/cloudstack/pull/1278#issuecomment-171284609
  
    @anshul1886 I am sorry if I wasn't clear. You are using the com.cloud.network.router.NetworkHelperImpl.startVirtualRouter(DomainRouterVO,
User, Account, Map<Param, Object>) method (implemented at line 347) which executes the
com.cloud.network.router.NetworkHelperImpl.start(DomainRouterVO, User, Account, Map<Param,
Object>, DeploymentPlan) method (line 266) with the user and account (modified by your
code). My point is that the user and account parameters are not used by the start method.
My suggestion is to remove those unused parameters from start and startVirtualRouter methods.
    
    Are you sure that the change you introduce fixed your problem? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message