cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nitin-maharana <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...
Date Tue, 12 Jan 2016 19:05:10 GMT
Github user nitin-maharana commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1319#discussion_r49498039
  
    --- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
    @@ -476,6 +476,25 @@ public VolumeVO doInTransaction(TransactionStatus status) {
             });
         }
     
    +    /**
    +     * Retrieves the volume name from CreateVolumeCmd object.
    +     *
    +     * If the retrieved volume name is null, empty or blank, then A random name
    +     * will be generated using getRandomVolumeName method.
    +     *
    +     * @param cmd
    +     * @return Either the retrieved name or a random name.
    +     */
    +    public String getVolumeNameFromCommand(CreateVolumeCmd cmd) {
    +        String userSpecifiedName = cmd.getVolumeName();
    +
    +        if (org.apache.commons.lang.StringUtils.isBlank(userSpecifiedName)) {
    --- End diff --
    
    @mike-tutkowski : Exactly there is one more StringUtils. If you put this it will conflict.
I tried in that way but it gives error.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message