cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From michaelandersen <...@git.apache.org>
Subject [GitHub] cloudstack pull request: [4.7] FIX Site2SiteVPN on redundant VPC
Date Mon, 11 Jan 2016 12:59:52 GMT
Github user michaelandersen commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1276#discussion_r49317967
  
    --- Diff: test/integration/smoke/test_vpc_vpn.py ---
    @@ -494,9 +526,411 @@ def create_natrule(self, vpc, vm, public_port, private_port, public_ip,
network,
             vm.public_port = int(public_port)
             return nat_rule
     
    +    def _validate_vpc_offering(self, vpc_offering):
    +
    +        self.logger.debug("Check if the VPC offering is created successfully?")
    +        vpc_offs = VpcOffering.list(
    +            self.apiclient,
    +            id=vpc_offering.id
    +        )
    +        self.assertEqual(
    --- End diff --
    
    @sanju1010 I implemented the validateList on both mentioned places


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message