cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cristofolini <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Factor in inaccurancy of System.nanoTime ...
Date Sun, 10 Jan 2016 18:49:45 GMT
Github user cristofolini commented on the pull request:

    https://github.com/apache/cloudstack/pull/1324#issuecomment-170381531
  
    I've had tests involving sleep calls fail on me seemingly arbitrarily, to the point where
simply re-running them would give me a passing result. I think something as simple as an I/O
or CPU scheduler could impact the measurement enough to make the test fail (I've seen different
rates of failure while fiddling around with the schedulers on my linux setup, but then again
that's anecdotal evidence at best). It also seems to me that the margin applied here is the
proper size to allow for a slightly more brand measure without being large to the point of
compromising test accuracy to a great degree. Code LGTM too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message