cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cristofolini <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9211: Support passing vRAM siz...
Date Sun, 10 Jan 2016 18:20:03 GMT
Github user cristofolini commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1310#discussion_r49279282
  
    --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
    @@ -1895,6 +1896,9 @@ protected StartAnswer execute(StartCommand cmd) {
     
                 postDiskConfigBeforeStart(vmMo, vmSpec, sortedDisks, ideControllerKey, scsiControllerKey,
iqnToPath, hyperHost, context);
     
    +            //Sets video card memory to the one provided in detail svga.vramSize (if
provided), 64MB was always set before
    --- End diff --
    
    I think a comment like this would be better located in a Javadoc style comment above the
`postVideoCardMemoryConfigBeforeStart` method itself, along with brief descriptions of the
parameters involved. This could make it easier to read/understand going forward. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message