cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GabrielBrascher <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9198: Virtual router gets depl...
Date Sun, 10 Jan 2016 00:26:41 GMT
Github user GabrielBrascher commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1278#discussion_r49269955
  
    --- Diff: server/src/com/cloud/network/router/NetworkHelperImpl.java ---
    @@ -509,7 +511,9 @@ public DomainRouterVO deployRouter(final RouterDeploymentDefinition
routerDeploy
     
                 if (startRouter) {
                     try {
    -                    router = startVirtualRouter(router, _accountMgr.getSystemUser(),
_accountMgr.getSystemAccount(), routerDeploymentDefinition.getParams());
    +                    final Account caller = CallContext.current().getCallingAccount();
    --- End diff --
    
    @anshul1886 could you please create a method for the new lines? As it is a duplicate code,
a method keeps the code clean and helps in future works (especially if well documented).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message