cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From koushik-das <...@git.apache.org>
Subject [GitHub] cloudstack pull request: [4.7] Critical VPCVR issues fixed: CLOUDS...
Date Sat, 09 Jan 2016 07:05:55 GMT
Github user koushik-das commented on the pull request:

    https://github.com/apache/cloudstack/pull/1277#issuecomment-170202865
  
    On latest master (without any fixes) I see that the config values (network.gc.interval
and network.gc.wait) are read correctly. Did the following:
    - Started MS
    - Changed the config values to 10 secs.
    - Restarted MS
    - Values read correctly and GC thread was running every 10 secs. Inside the GC thread
correct value was shown for gc.wait
    
    @wilderrodrigues On which branch did you notice this issue? Or is it possible that the
issue is something else?
    -1 for commit a0a230a/CLOUDSTACK-9188 based on the test on master.
    
    Regarding these network gc configs, the only cleanup that can be done on the code is to
remove the entries from Config.java as they are already defined in NetworkOrchestrator.java.
This can go as a separate PR as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message