cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wilderrodrigues <...@git.apache.org>
Subject [GitHub] cloudstack pull request: [4.7] Critical VPCVR issues fixed: CLOUDS...
Date Fri, 08 Jan 2016 14:27:25 GMT
Github user wilderrodrigues commented on the pull request:

    https://github.com/apache/cloudstack/pull/1277#issuecomment-170017549
  
    Try something, @koushik-das:
    
    ```
    Do not use this code for the steps below, but Master instead.
    ```
    
    1. Deploy a DC
    2. Create a VPC + Tier + VM
    3. Change the GC settings for 10 seconds, for example
    4. Restart the Management Server
    5. Remove the VM from the tier
    6. Observe if the Network GC is actually running every 10 seconds - as now defined in
the DB - or if it is still using the 600 seconds hardcoded in the nested Enum.
    
    That's why a changed it. I needed to make sure that the changes applied in the global
settings would be retrieved from the Database. But don't bother, it's already deployed in
our production here and working really nice.
    
    Concerning gradually refactoring code, I agree with that - I'm not an idiot. Actually,
I have done a lot of refactoring on ACS since I started. I haven't been adding glue to things
or not writing tests. But in that case, the whole configuration is messed and I don't agree
with someone adding separate things to classes and letting them be for years.
    
    If for some reason I did not get the way it should work, you can do one of two things:
    
    1. Mark the PR with a -1; or
    2. Checkout the code; fix the way you want; make sure the tests passes; and push a PR
on top of this one.
    
    Have a happy coding.
    
    Cheers,
    Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message