cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wilderrodrigues <...@git.apache.org>
Subject [GitHub] cloudstack pull request: [4.7] Critical VPCVR issues fixed: CLOUDS...
Date Fri, 08 Jan 2016 08:59:32 GMT
Github user wilderrodrigues commented on the pull request:

    https://github.com/apache/cloudstack/pull/1277#issuecomment-169939093
  
    @DaanHoogland and @koushik-das 
    
    I split the commits and pushed the changes. You now should be able to review the actual
changes I have applied to NetworkOchestrator file. The commit ID is a0a230af7b1eb1bf24da8ed0d9e2d1a4fc6a5fe4
    
    I built the source, including unit tests execution, to make sure all compiles and I also
did a diff between the old file and the 1 changes after the 2 commits.
    
    * Build result
    ```
    [INFO] ------------------------------------------------------------------------
    [INFO] BUILD SUCCESS
    [INFO] ------------------------------------------------------------------------
    [INFO] Total time: 17:44 min
    [INFO] Finished at: 2016-01-08T09:49:24+01:00
    [INFO] Final Memory: 121M/947M
    [INFO] ------------------------------------------------------------------------
    ```
    
    * Diff output
    ```
    sbpltk1zffh04:asf_cloudstack wrodrigues$ diff ~/dev/gc_net.java engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
    3352d3351
    < 
    ```
    
    As you can see, the difference is irrelevant.
    
    Cheers,
    Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message