Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: borisroman <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1242-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1242-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: test: Fix Libvirt test so that it
 works o...
Content-Type: text/plain
Message-Id: <20151214131506.62CD2E0593@git1-us-west.apache.org>
Date: Mon, 14 Dec 2015 13:15:06 +0000 (UTC)

Github user borisroman commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1242#discussion_r47495397
  
    --- Diff: plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtUtilitiesHelperTest.java ---
    @@ -37,8 +38,8 @@ public void testSSHKeyPaths() {
              * Hardcoded paths are not what we want in the longer run
              */
             assertEquals("/root/.ssh", helper.retrieveSshKeysPath());
    -        assertEquals("/root/.ssh/id_rsa.pub.cloud", helper.retrieveSshPubKeyPath());
    -        assertEquals("/root/.ssh/id_rsa.cloud", helper.retrieveSshPrvKeyPath());
    +        assertEquals("/root/.ssh" + File.separator + "id_rsa.pub.cloud", helper.retrieveSshPubKeyPath());
    --- End diff --
    
    The root path isn't available at all in Windows right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---