Return-Path: 
 <dev-return-86809-apmail-cloudstack-dev-archive=cloudstack.apache.org@cloudstack.apache.org>
X-Original-To: apmail-cloudstack-dev-archive@www.apache.org
Delivered-To: apmail-cloudstack-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 140A718996
	for <apmail-cloudstack-dev-archive@www.apache.org>;
 Mon, 14 Dec 2015 11:00:20 +0000 (UTC)
Received: (qmail 46872 invoked by uid 500); 14 Dec 2015 11:00:19 -0000
Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org
Received: (qmail 46816 invoked by uid 500); 14 Dec 2015 11:00:19 -0000
Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cloudstack.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cloudstack.apache.org>
List-Post: <mailto:dev@cloudstack.apache.org>
List-Id: <dev.cloudstack.apache.org>
Reply-To: dev@cloudstack.apache.org
Delivered-To: mailing list dev@cloudstack.apache.org
Received: (qmail 46804 invoked by uid 99); 14 Dec 2015 11:00:19 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Dec 2015 11:00:19 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 4F7D2DFF8D; Mon, 14 Dec 2015 11:00:19 +0000 (UTC)
From: DaanHoogland <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1240-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1240-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: CLOUDSTACK-9161: fix the quota
 marvin tes...
Content-Type: text/plain
Message-Id: <20151214110019.4F7D2DFF8D@git1-us-west.apache.org>
Date: Mon, 14 Dec 2015 11:00:19 +0000 (UTC)

Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1240#discussion_r47484403
  
    --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java ---
    @@ -186,7 +186,7 @@ public int compare(QuotaBalanceVO o1, QuotaBalanceVO o2) {
             //check that there is at least one balance entry
             for (Iterator<QuotaBalanceVO> it = quotaBalance.iterator(); it.hasNext();) {
                 QuotaBalanceVO entry = it.next();
    -            if (entry.getCreditsId() > 0) {
    +            if (entry.getCreditsId() == 0) {
    --- End diff --
    
    ok, i understand, i think, thanks. At least this code makes sense now ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---