Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: wilderrodrigues <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1214-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1214-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: Setup routes for RFC 1918 ip space
Content-Type: text/plain
Message-Id: <20151211175649.DFA5DE057A@git1-us-west.apache.org>
Date: Fri, 11 Dec 2015 17:56:49 +0000 (UTC)

Github user wilderrodrigues commented on the pull request:

    https://github.com/apache/cloudstack/pull/1214#issuecomment-164003619
  
    Put some time in reading the RFC - yes, I actually did - and also went through the code (with the latest changes). It LGTM :+1: 
    
    I think last @terbolous comment was sent just after @remibergsma made the change, which checks if the pub IP is within the range reserved by the RFC.
    
    Thanks for the fix, @remibergsma !
    
    Cheers,
    Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---