Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: agneya2001 <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1212-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1212-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: CLOUDSTACK-9136: remove ssh
 keypairs alon...
Content-Type: text/plain
Message-Id: <20151211134649.1628CE0513@git1-us-west.apache.org>
Date: Fri, 11 Dec 2015 13:46:49 +0000 (UTC)

Github user agneya2001 commented on the pull request:

    https://github.com/apache/cloudstack/pull/1212#issuecomment-163939898
  
    Sorry, I just started looking at PRs, next time I will elaborate on my LGTM.
    For this particular one when a account is deleted it leaves the ssh key in the user table. Since, it is a few line fix I did a code review and it shows that the code will remove the ssh keys for all users under a removed account. Leaving ssh keys in db is not a good idea. This issue is there in 4.7 too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---