Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4ACBD18BCD for ; Thu, 10 Dec 2015 10:01:53 +0000 (UTC) Received: (qmail 18878 invoked by uid 500); 10 Dec 2015 10:01:52 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 18821 invoked by uid 500); 10 Dec 2015 10:01:52 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 18810 invoked by uid 99); 10 Dec 2015 10:01:52 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Dec 2015 10:01:52 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 413D5E1530; Thu, 10 Dec 2015 10:01:52 +0000 (UTC) From: remibergsma To: dev@cloudstack.apache.org Reply-To: dev@cloudstack.apache.org References: In-Reply-To: Subject: [GitHub] cloudstack pull request: CLOUDSTACK-9131: Create a new API to chec... Content-Type: text/plain Message-Id: <20151210100152.413D5E1530@git1-us-west.apache.org> Date: Thu, 10 Dec 2015 10:01:52 +0000 (UTC) Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1201#issuecomment-163562169 LGTM, both users and admins can login with/without this plugin enabled. User login with plugin disabled: ![screen shot 2015-12-10 at 10 52 03](https://cloud.githubusercontent.com/assets/1630096/11712364/db9e8da4-9f2c-11e5-9ba2-40bce6da2aba.png) Enabled plugin, restarted mgt afterwards: ![screen shot 2015-12-10 at 10 53 29](https://cloud.githubusercontent.com/assets/1630096/11712356/ce88281e-9f2c-11e5-87bf-56f403b95a06.png) Admin with plugin enabled: ![screen shot 2015-12-10 at 10 55 44](https://cloud.githubusercontent.com/assets/1630096/11712349/c34388b8-9f2c-11e5-988e-b7f795dfdf36.png) User with plugin enabled: ![screen shot 2015-12-10 at 10 56 05](https://cloud.githubusercontent.com/assets/1630096/11712346/b9fab7f4-9f2c-11e5-99e7-ce1f0694269b.png) Pinging @DaanHoogland to also review. I will also start some integration tests to be sure. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---