Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3A8A5188BF for ; Mon, 7 Dec 2015 18:33:34 +0000 (UTC) Received: (qmail 65570 invoked by uid 500); 7 Dec 2015 18:33:33 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 65513 invoked by uid 500); 7 Dec 2015 18:33:33 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 65494 invoked by uid 99); 7 Dec 2015 18:33:33 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Dec 2015 18:33:33 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 73ACBE0850; Mon, 7 Dec 2015 18:33:33 +0000 (UTC) From: wilderrodrigues To: dev@cloudstack.apache.org Reply-To: dev@cloudstack.apache.org References: In-Reply-To: Subject: [GitHub] cloudstack pull request: Prevent live-lock in NSX API client Content-Type: text/plain Message-Id: <20151207183333.73ACBE0850@git1-us-west.apache.org> Date: Mon, 7 Dec 2015 18:33:33 +0000 (UTC) Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1178#issuecomment-162616790 @miguelaferreira gave me some explanations about the problem and how he was going to fix it. I went through the code and also checked the tests he wrote. Based on his tests results, the tests @remibergsma execute and the review I did, this PR LGMT :+1: Cheers, Wilder --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---