Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: jburwell <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-768-cloudstack@git.apache.org>
In-Reply-To: <git-pr-768-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: Quota
Content-Type: text/plain
Message-Id: <20151207034046.A4780E00DE@git1-us-west.apache.org>
Date: Mon,  7 Dec 2015 03:40:46 +0000 (UTC)

Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/768#discussion_r46784547
  
    --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaBalanceCmd.java ---
    @@ -0,0 +1,125 @@
    +//Licensed to the Apache Software Foundation (ASF) under one
    +//or more contributor license agreements.  See the NOTICE file
    +//distributed with this work for additional information
    +//regarding copyright ownership.  The ASF licenses this file
    +//to you under the Apache License, Version 2.0 (the
    +//"License"); you may not use this file except in compliance
    +//with the License.  You may obtain a copy of the License at
    +//
    +//http://www.apache.org/licenses/LICENSE-2.0
    +//
    +//Unless required by applicable law or agreed to in writing,
    +//software distributed under the License is distributed on an
    +//"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +//KIND, either express or implied.  See the License for the
    +//specific language governing permissions and limitations
    +//under the License.
    +package org.apache.cloudstack.api.command;
    +
    +import java.util.Date;
    +import java.util.List;
    +
    +import javax.inject.Inject;
    +
    +import org.apache.log4j.Logger;
    +import org.apache.cloudstack.api.APICommand;
    +import org.apache.cloudstack.api.ApiConstants;
    +import org.apache.cloudstack.api.BaseCmd;
    +import org.apache.cloudstack.api.Parameter;
    +import org.apache.cloudstack.api.response.AccountResponse;
    +import org.apache.cloudstack.api.response.DomainResponse;
    +import org.apache.cloudstack.api.response.QuotaBalanceResponse;
    +import org.apache.cloudstack.api.response.QuotaResponseBuilder;
    +import org.apache.cloudstack.quota.vo.QuotaBalanceVO;
    +import org.apache.cloudstack.api.response.QuotaStatementItemResponse;
    +
    +@APICommand(name = "quotaBalance", responseObject = QuotaStatementItemResponse.class, description = "Create a quota balance statement", since = "4.6.0", requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
    +public class QuotaBalanceCmd extends BaseCmd {
    +
    +    public static final Logger s_logger = Logger.getLogger(QuotaBalanceCmd.class);
    +
    +    private static final String s_name = "quotabalanceresponse";
    +
    +    @Parameter(name = ApiConstants.ACCOUNT, type = CommandType.STRING, required = true, description = "Account Id for which statement needs to be generated")
    +    private String accountName;
    +
    +    @Parameter(name = ApiConstants.DOMAIN_ID, type = CommandType.UUID, required = true, entityType = DomainResponse.class, description = "If domain Id is given and the caller is domain admin then the statement is generated for domain.")
    +    private Long domainId;
    +
    +    @Parameter(name = ApiConstants.END_DATE, type = CommandType.DATE, description = "End date range for quota query. Use yyyy-MM-dd as the date format, e.g. startDate=2009-06-03.")
    +    private Date endDate;
    +
    +    @Parameter(name = ApiConstants.START_DATE, type = CommandType.DATE, description = "Start date range quota query. Use yyyy-MM-dd as the date format, e.g. startDate=2009-06-01.")
    +    private Date startDate;
    +
    +    @Parameter(name = ApiConstants.ACCOUNT_ID, type = CommandType.UUID, entityType = AccountResponse.class, description = "List usage records for the specified account")
    +    private Long accountId;
    +
    +    @Inject
    +    QuotaResponseBuilder _responseBuilder;
    +
    +    public Long getAccountId() {
    +        return accountId;
    +    }
    +
    +    public void setAccountId(Long accountId) {
    +        this.accountId = accountId;
    +    }
    +
    +    public String getAccountName() {
    +        return accountName;
    +    }
    +
    +    public void setAccountName(String accountName) {
    +        this.accountName = accountName;
    +    }
    +
    +    public Long getDomainId() {
    +        return domainId;
    +    }
    +
    +    public void setDomainId(Long domainId) {
    +        this.domainId = domainId;
    +    }
    +
    +    public Date getEndDate() {
    +        return endDate == null ? null : _responseBuilder.startOfNextDay(endDate);
    +    }
    +
    +    public void setEndDate(Date endDate) {
    +        this.endDate = endDate;
    --- End diff --
    
    Since ``Date``s are mutable, ``endDate`` should be copied before being set to ``this.endDate`` to avoid downstream side-effects.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---