cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nitin-maharana <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...
Date Mon, 21 Dec 2015 07:29:04 GMT
GitHub user nitin-maharana opened a pull request:

    https://github.com/apache/cloudstack/pull/1264

    CLOUDSTACK-9192: UpdateVpnCustomerGateway is failing

    Reproducible Steps:
    ================
    1.Create a customer gateway for a VPC.
    2.Edit it using UI(API call is UpdateVpnCustomerGateway).
    3.When we try to update the customer vpn gateway with connection state is not in "Error",
we see the API error but that won't be reflected to the user in UI.
    
    Actual Behaviour:
    ==============
    The API throws error. But UI doesn't show it to user.
    
    Expected Behaviour:
    =================
    The UI should show the error to user.
    
    Fix:
    ===
    TypeError: json.updatecustomergatewayresponse is undefined
    The response name was wrong so corrected it.
    It should be json.updatevpncustomergatewayresponse.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nitin-maharana/CloudStack CloudStack-Nitin10

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1264.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1264
    
----
commit 3022dd3094d45d6574c4d68d3a0b4e6ffde6ad11
Author: Nitin Kumar Maharana <nitin.maharana@gmail.com>
Date:   2015-12-21T07:37:33Z

    CLOUDSTACK-9192: UpdateVpnCustomerGateway is failing
    
    The response name was wrong so corrected it.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message