cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From borisroman <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9158: Removed SLF4J, it's abun...
Date Sun, 13 Dec 2015 15:54:31 GMT
GitHub user borisroman opened a pull request:

    https://github.com/apache/cloudstack/pull/1236

    CLOUDSTACK-9158: Removed SLF4J, it's abundant due to log4j

    In the entire project we use log4j, so why also use slf4j? I've removed slf4j and all
references to it from the codebase.
    
    Also I've let the top-level pom depend on log4j so not every project has to define it
for itself.
    
    Ping @remibergsma @DaanHoogland @miguelaferreira @wilderrodrigues @wido 
    
    Builds ok, running integration tests now!
    ```
    [INFO] ------------------------------------------------------------------------
    [INFO] BUILD SUCCESS
    [INFO] ------------------------------------------------------------------------
    [INFO] Total time: 6:33.329s
    [INFO] Finished at: Sun Dec 13 16:53:55 CET 2015
    [INFO] Final Memory: 104M/813M
    [INFO] ------------------------------------------------------------------------
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/borisroman/cloudstack CLOUDSTACK-9158

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1236.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1236
    
----
commit e7a6a0a38e36bc8deac7aa77b0aa624aa055bc1b
Author: Boris Schrijver <boris@pcextreme.nl>
Date:   2015-12-13T15:04:57Z

    CLOUDSTACK-9158: Remove SLF4J, it's abundant due to log4j

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message