cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From remibergsma <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9155 make sure logrotate is ef...
Date Sun, 13 Dec 2015 11:01:51 GMT
GitHub user remibergsma opened a pull request:

    https://github.com/apache/cloudstack/pull/1235

    CLOUDSTACK-9155 make sure logrotate is effective for cloud.log

    Many processes on the VRs log to cloud.log. When log rotate kicks in, the file is rotated
but the scripts still write to the old inode (cloud.log.1 after rotate). Tis quickly fills
up the tiny log partition.
    
    Using 'copytruncate' is a small tradeoff, there is a slight change of missing a log entry,
but in the old situation nothing ended up in cloud.log after rotate (except for stuff that
was (re)started) so I think this is the best solution until we properly rewrite the script
to either use their own script or syslog.
    
    More details: https://issues.apache.org/jira/browse/CLOUDSTACK-9155

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/remibergsma/cloudstack fix-passwd-server-logging

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1235.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1235
    
----
commit 0742535e13c51372c63b045181d6a20198fb397e
Author: Remi Bergsma <github@remi.nl>
Date:   2015-12-13T10:53:45Z

    CLOUDSTACK-9155 make sure logrotate is effective
    
    Many processes on the VRs log to cloud.log. When logrotate
    kicks in, the file is rotated but the scripts still write
    to the old inode (cloud.log.1 after rotate). Tis quickly
    fills up the tiny log partition.
    
    Using 'copytruncate' is a tradeoff, there is a slight
    change of missing a log entry, but in the old situation
    we were missing all of them after logrotate.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message