cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wilderrodrigues <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9106 - As a Developer I want t...
Date Sat, 05 Dec 2015 18:36:24 GMT
GitHub user wilderrodrigues opened a pull request:

    https://github.com/apache/cloudstack/pull/1179

    CLOUDSTACK-9106 - As a Developer I want the Redundant VPC private gateway feature fixed

    This PR fixes the Private Gateway feature when using Redundant VPCs.
    
    In order to get it to work, I had to refactor some of the Java code in order to reduce
the number of iterations we had with the routers list. It caused an issue when trying to configure
ACL rules in a router (the backup one) that did not have the interface setup yet.
    
    The rVPC Pvt GW integration test is not being skipped anymore and is 100% green!

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ekholabs/cloudstack fix/rvpc-pvtgw-CLOUDSTACK-9106

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1179.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1179
    
----
commit ae325f601605c2dec285db621660bacdc2959d4b
Author: Wilder Rodrigues <wrodrigues@schubergphilis.com>
Date:   2015-12-04T17:41:03Z

    CLOUDSTACK-9106 - Reduces the amount of iterations through the routers of a VPC
    
       - It was causing problems because Nics were expected to be plugged before they actually
exist. Only in rVPC cases.
       - Applies ACL items to routers only after the Pvt GW is setup.

commit 78e15d1cfa27937935f1269c9e9b6ec5a91db08f
Author: Wilder Rodrigues <wrodrigues@schubergphilis.com>
Date:   2015-12-05T13:03:50Z

    CLOUDSTACK-9106 - Refactor the createPrivateNicProfileForGateway() method
    
        - Use the router to retrieve the instance ID
        - Check if the VPC is redundant in order to reuse the private gateway address.
        - Brings the private gateways interfaces up.

commit 6dab3613e475aac524e448f0d52fe575fbdf5e23
Author: Wilder Rodrigues <wrodrigues@schubergphilis.com>
Date:   2015-12-05T16:33:55Z

    CLOUDSTACK-9106 - Enables private gateway tests on Redundant VPCs

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message