cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daan Hoogland <daan.hoogl...@gmail.com>
Subject Re: PR's and the 2 LGTM Story
Date Mon, 14 Dec 2015 16:40:35 GMT
You have been doing this blindly and I don't accept this
I have applied the mentioned code directly to master. Next time first see
if you can add your lgtm and whether the code is needed.

On Mon, Dec 14, 2015 at 4:58 PM, Boris Schrijver <boris@pcextreme.nl> wrote:

> Hi all,
>
> Just to make this clear once more. A PR needs two LGTM's. One of them
> needs to
> run the integration- and unit-tests. While the other does code review.
>
> This is a the minimal requirement. More is always welcome, anything less
> will be
> reverted.
>
> I just enforced this policy [1]. Any active committer has at all times the
> right
> to do so.
>
> [1]
>
> https://github.com/apache/cloudstack/commit/a00fef8c332ebaede32c46cbf3065f4acaa91f02
>
> --
>
> Met vriendelijke groet / Kind regards,
>
> Boris Schrijver
>
> PCextreme B.V.
>
> http://www.pcextreme.nl/contact
> Tel direct: +31 (0) 118 700 215
>



-- 
Daan

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message