cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <...@git.apache.org>
Subject [GitHub] cloudstack pull request: [4.7] FIX Site2SiteVPN on redundant VPC
Date Wed, 23 Dec 2015 14:58:41 GMT
Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1276#discussion_r48350750
  
    --- Diff: test/integration/smoke/test_vpc_vpn.py ---
    @@ -468,7 +500,7 @@ def get_ssh_client(self, virtual_machine, services, retries):
     
             return ssh_client
     
    -    def create_natrule(self, vpc, vm, public_port, private_port, public_ip, network,
services=None):
    +    def _create_natrule(self, vpc, vm, public_port, private_port, public_ip, network,
services=None):
    --- End diff --
    
    why _create_natrule() and not create_natrule()?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message