cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From michaelandersen <...@git.apache.org>
Subject [GitHub] cloudstack pull request: [4.7] FIX Site2SiteVPN on redundant VPC
Date Tue, 22 Dec 2015 19:43:04 GMT
Github user michaelandersen commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1276#discussion_r48290122
  
    --- Diff: server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
---
    @@ -916,6 +916,9 @@ protected void updateSite2SiteVpnConnectionState(final List<DomainRouterVO>
rout
                     }
                     continue;
                 }
    +            if (router.getIsRedundantRouter() && router.getRedundantState() !=
RedundantState.MASTER){
    --- End diff --
    
    ok @pdube so getConnectionsForRouter() returns vpn connections based on the vpcid of the
router. As both the backup and master router have the same vpcid assigned it makes sense to
first exclude backup routers and then to exclude non-running routers. 
    
    I forced pushed the change. @pdube could you test?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message