cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bhaisaab <...@git.apache.org>
Subject [GitHub] cloudstack pull request: [4.7.0/master] DB Paths fixes: 4.5.3->4.7...
Date Fri, 18 Dec 2015 12:31:28 GMT
Github user bhaisaab commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1247#discussion_r48020663
  
    --- Diff: engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java ---
    @@ -242,13 +243,13 @@ public DatabaseUpgradeChecker() {
     
             _upgradeMap.put("4.5.2", new DbUpgrade[] {new Upgrade452to460(), new Upgrade460to461(),
new Upgrade461to470()});
     
    -        _upgradeMap.put("4.5.3", new DbUpgrade[] {new Upgrade453to460()});
    +        _upgradeMap.put("4.5.3", new DbUpgrade[] {new Upgrade453to460(), new Upgrade460to461(),
new Upgrade461to470()});
     
             _upgradeMap.put("4.6.0", new DbUpgrade[] {new Upgrade460to461(), new Upgrade461to470()});
     
             _upgradeMap.put("4.6.1", new DbUpgrade[] {new Upgrade461to470()});
     
    -        _upgradeMap.put("4.6.2", new DbUpgrade[] {new Upgrade461to470()});
    +        _upgradeMap.put("4.6.2", new DbUpgrade[] {new Upgrade462to470()});
    --- End diff --
    
    The PR tries to make the usage be consistent with the implementation and usage; see Upgrade453to460
class for example. The fix here is mainly for the 4.5.3 version, 4.6.2 upgrade path is semantically
broken while it still works is another thing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message