cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From resmo <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9174: A deleted account result...
Date Thu, 17 Dec 2015 17:07:33 GMT
Github user resmo commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1254#discussion_r47931786
  
    --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaSummaryCmd.java
---
    @@ -59,7 +59,7 @@ public QuotaSummaryCmd() {
         public void execute() {
             Account caller = CallContext.current().getCallingAccount();
             List<QuotaSummaryResponse> responses;
    -        if (caller.getAccountId() <= 2) { //non root admin or system
    +        if (caller.getAccountId() <= 2) { // root admin or system
    --- End diff --
    
    to assume that an account <=2 has root admin privileges is just naive. There must be
a solid way to do this. Just my 2 cents..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message