cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wido <...@git.apache.org>
Subject [GitHub] cloudstack pull request: test: Fix Libvirt test so that it works o...
Date Mon, 14 Dec 2015 13:19:41 GMT
Github user wido commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1242#discussion_r47495825
  
    --- Diff: plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtUtilitiesHelperTest.java
---
    @@ -37,8 +38,8 @@ public void testSSHKeyPaths() {
              * Hardcoded paths are not what we want in the longer run
              */
             assertEquals("/root/.ssh", helper.retrieveSshKeysPath());
    -        assertEquals("/root/.ssh/id_rsa.pub.cloud", helper.retrieveSshPubKeyPath());
    -        assertEquals("/root/.ssh/id_rsa.cloud", helper.retrieveSshPrvKeyPath());
    +        assertEquals("/root/.ssh" + File.separator + "id_rsa.pub.cloud", helper.retrieveSshPubKeyPath());
    --- End diff --
    
    @DaanHoogland True, but the test still works :)
    
    @borisroman Yes, but this is just to make the Unit Tests work under Windows.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message