cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9161: fix the quota marvin tes...
Date Mon, 14 Dec 2015 11:00:49 GMT
Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1240#discussion_r47484456
  
    --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
    @@ -186,7 +186,7 @@ public int compare(QuotaBalanceVO o1, QuotaBalanceVO o2) {
             //check that there is at least one balance entry
             for (Iterator<QuotaBalanceVO> it = quotaBalance.iterator(); it.hasNext();)
{
                 QuotaBalanceVO entry = it.next();
    -            if (entry.getCreditsId() > 0) {
    +            if (entry.getCreditsId() == 0) {
    --- End diff --
    
    BTW i would factor this out as a boolean checker method


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message