cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bhaisaab <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...
Date Sun, 13 Dec 2015 16:00:07 GMT
Github user bhaisaab commented on the pull request:

    https://github.com/apache/cloudstack/pull/1224#issuecomment-164270707
  
    @DaanHoogland @borisroman - I sincerely don't grok the benefits of these changes, which
is why I'm asking what are the benefits of the changes?
    
    Some potential issues I can think of, wrt changing file names and paths are: (1) doing
branch maintenance will become difficult, so cherry-picks and backporting bugfixes will become
error prone, (2) while switching branches IDEs will be slow as they would need to re-index
files/paths, (3) it becomes difficult to diff across branches (like git diff branch1..branch2
some/file/path/file.txt) as files/paths have changed (I for example run sanity checks in db
related files to make sure we don't change older db paths etc). 
    
    While I understand, Maven users want to have convention over configuration, other than
that argument I don't understand the pros. I would request that you please hold this PR for
merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message