cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Changed UsageEventUtils to UsageEventEmit...
Date Sat, 12 Dec 2015 19:47:19 GMT
Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1191#discussion_r47435795
  
    --- Diff: engine/components-api/src/com/cloud/event/UsageEventEmitterImpl.java ---
    @@ -131,54 +127,55 @@ public static void publishUsageEvent(String usageType, long accountId,
long zone
     
         }
     
    -    private static void saveUsageEvent(String usageType, long accountId, long zoneId,
long resourceId, String resourceName, Long offeringId, Long templateId,
    +    private void saveUsageEvent(String usageType, long accountId, long zoneId, long resourceId,
String resourceName, Long offeringId, Long templateId,
             String resourceType, Map<String, String> details) {
             UsageEventVO usageEvent = new UsageEventVO(usageType, accountId, zoneId, resourceId,
resourceName, offeringId, templateId, resourceType);
    -        s_usageEventDao.persist(usageEvent);
    -        s_usageEventDao.saveDetails(usageEvent.getId(), details);
    +        _usageEventDao.persist(usageEvent);
    --- End diff --
    
    please change to usageEventDao. no reason in morden days to use these prefixes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message