cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Changed UsageEventUtils to UsageEventEmit...
Date Sat, 12 Dec 2015 19:46:07 GMT
Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1191#discussion_r47435785
  
    --- Diff: engine/components-api/src/com/cloud/event/UsageEventEmitterImpl.java ---
    @@ -38,44 +34,37 @@
     import com.cloud.event.dao.UsageEventDao;
     import com.cloud.user.Account;
     import com.cloud.user.dao.AccountDao;
    -import com.cloud.utils.component.ComponentContext;
     
    -public class UsageEventUtils {
     
    -    private static UsageEventDao s_usageEventDao;
    -    private static AccountDao s_accountDao;
    -    private static DataCenterDao s_dcDao;
    -    private static final Logger s_logger = Logger.getLogger(UsageEventUtils.class);
    -    protected static EventBus s_eventBus = null;
    -    protected static ConfigurationDao s_configDao;
    +public class UsageEventEmitterImpl implements UsageEventEmitter {
     
    +    private static final Logger s_logger = Logger.getLogger(UsageEventEmitterImpl.class);
    +
    +    @Inject
    +    UsageEventDao _usageEventDao;
    --- End diff --
    
    please do not prefix members with '_'


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message