cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From borisroman <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9136: remove ssh keypairs alon...
Date Sat, 12 Dec 2015 19:38:30 GMT
Github user borisroman commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1212#discussion_r47435698
  
    --- Diff: server/test/com/cloud/user/AccountManagerImplTest.java ---
    @@ -185,6 +186,8 @@
         @Mock
         GlobalLoadBalancerRuleDao _gslbRuleDao;
         @Mock
    +    SSHKeyPairDao _sshKeyPairDao;
    --- End diff --
    
    You've added _sshKeyPairDao here. Without using it! Could you please write a test for
the functionality you improved?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message