cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wilderrodrigues <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9135 - As a Developer I want t...
Date Sat, 12 Dec 2015 09:57:30 GMT
Github user wilderrodrigues commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1221#discussion_r47429990
  
    --- Diff: test/integration/smoke/test_internal_lb.py ---
    @@ -286,9 +302,12 @@ def setUpClass(cls):
                        %s" % (cls.account.name,
                               cls.account.id))
     
    -        cls.cleanup = [cls.template, cls.account, cls.compute_offering]
    +        cls._cleanup = [cls.template, cls.account, cls.compute_offering]
    --- End diff --
    
    Hi @borisroman
    
    I added a setUp() and tearDown() methods that are called before/after each test. By doing
so, we make sure that each test is done in isolation.
    
    The tearDown() method uses the cleanup list, whilst the tearDownClass() method uses the
_cleanup list.
    
    The tearDownClass() is called only when all the tests are done.
    
    :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message