cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bhaisaab <...@git.apache.org>
Subject [GitHub] cloudstack pull request: QUOTA: Ensuring that the dates displayed ...
Date Fri, 11 Dec 2015 09:13:02 GMT
Github user bhaisaab commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1205#discussion_r47333986
  
    --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
    @@ -233,9 +233,9 @@ public int compare(QuotaBalanceVO o1, QuotaBalanceVO o2) {
                 // order is desc last item is the start item
                 QuotaBalanceVO startItem = quotaBalance.get(quotaBalance.size() - 1);
                 QuotaBalanceVO endItem = quotaBalance.get(0);
    -            resp.setStartDate(startItem.getUpdatedOn());
    +            resp.setStartDate(startDate);
    --- End diff --
    
    instead of startDate, pass a new object like new Date(startDate.getTime()) for the ref
issue we discovered with the earlier PR. Alternatively, you may fix the setters and getters
to do return or set using new Date() syntax


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message