cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wilderrodrigues <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9114: restartnetwork with clea...
Date Fri, 11 Dec 2015 07:50:15 GMT
Github user wilderrodrigues commented on the pull request:

    https://github.com/apache/cloudstack/pull/1198#issuecomment-163867468
  
    @remibergsma @DaanHoogland 
    
    This PR Looks Okay To Me, no good, but okay. Please merge it and I will improve the code
and add Marvin tests to cover it because @ustcweizhou said he is too busy to do that.
    
    I'm also busy, we are all busy. It should not be used as excuse to avoid writing tests.
Even our managers know that.
    
    I went into berserker mode and told him that next PR without tests will get a -1 from
me, and I will hold to that promise.
    
    Cheers,
    Wilder  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message