cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wilderrodrigues <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9127 Missing PV-bootloader-arg...
Date Thu, 10 Dec 2015 10:54:55 GMT
Github user wilderrodrigues commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1196#discussion_r47212450
  
    --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixHelper.java
---
    @@ -236,4 +236,15 @@ public static String getProductVersion(final Host.Record record)
{
             }
             return prodVersion;
         }
    +
    +    public static String getPVbootloaderArgs(String guestOS) {
    +        if (guestOS.startsWith("SUSE Linux Enterprise Server")) {
    +            if (guestOS.contains("64-bit")) {
    +                return "--kernel /boot/vmlinuz-xen --ramdisk /boot/initrd-xen";
    +            } else if (guestOS.contains("32-bit")) {
    +                return "--kernel /boot/vmlinuz-xenpae --ramdisk /boot/initrd-xenpae";
    +            }
    +        }
    +        return "";
    +    }
    --- End diff --
    
    Change looks good and simple. Could you please add an unit test to cover the new method?
    
    Cheers,
    Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message