cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From remibergsma <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9131: Create a new API to chec...
Date Thu, 10 Dec 2015 10:01:52 GMT
Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/1201#issuecomment-163562169
  
    LGTM, both users and admins can login with/without this plugin enabled.
    
    User login with plugin disabled:
    ![screen shot 2015-12-10 at 10 52 03](https://cloud.githubusercontent.com/assets/1630096/11712364/db9e8da4-9f2c-11e5-9ba2-40bce6da2aba.png)
    
    Enabled plugin, restarted mgt afterwards:
    ![screen shot 2015-12-10 at 10 53 29](https://cloud.githubusercontent.com/assets/1630096/11712356/ce88281e-9f2c-11e5-87bf-56f403b95a06.png)
    
    Admin with plugin enabled:
    ![screen shot 2015-12-10 at 10 55 44](https://cloud.githubusercontent.com/assets/1630096/11712349/c34388b8-9f2c-11e5-988e-b7f795dfdf36.png)
    
    User with plugin enabled:
    ![screen shot 2015-12-10 at 10 56 05](https://cloud.githubusercontent.com/assets/1630096/11712346/b9fab7f4-9f2c-11e5-99e7-ce1f0694269b.png)
    
    Pinging @DaanHoogland to also review.
    
    I will also start some integration tests to be sure.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message