cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9094: Multiple threads are bei...
Date Mon, 07 Dec 2015 09:40:00 GMT
Github user DaanHoogland commented on the pull request:

    https://github.com/apache/cloudstack/pull/1140#issuecomment-162464615
  
    Guys, this got merged on only code review. No tests are described showing the old and
new behaviours. No unit tests are added. No regression tests are added. It is like this fix
is not important.
    
    My intuition says that if the VpcVirtualNetworkApplianceManager.start() is called then
VirtualNetworkApplianceManager.start() should not have been and the real bug is not in this
code at all.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message