cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Quota
Date Mon, 07 Dec 2015 03:53:11 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/768#discussion_r46784930
  
    --- Diff: api/src/org/apache/cloudstack/api/command/admin/usage/GetUsageRecordsCmd.java
---
    @@ -111,6 +111,30 @@ public Long getProjectId() {
         public String getUsageId() {
             return usageId;
         }
    +    public void setAccountName(String accountName) {
    +        this.accountName = accountName;
    +    }
    +
    +    public void setDomainId(Long domainId) {
    +        this.domainId = domainId;
    +    }
    +
    +    public void setEndDate(Date endDate) {
    +        this.endDate = endDate;
    +    }
    +
    +    public void setStartDate(Date startDate) {
    +        this.startDate = startDate;
    --- End diff --
    
    @abhinandanprateek it's not a matter of it being modified in that time period.  Since
the value being passed is simply a pointer, any modification to that value after calling this
method will change the value.  All dates should be defensively copied for this reason.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message