cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...
Date Sun, 06 Dec 2015 20:18:07 GMT
Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1150#discussion_r46775285
  
    --- Diff: ui/scripts/instanceWizard.js ---
    @@ -731,25 +746,33 @@
     
                 //step 1 : select zone
                 $.extend(deployVmData, {
    -                zoneid : args.data.zoneid
    +                zoneid : selectedZoneObj.id
                 });
     
                 //step 2: select template
    -            $.extend(deployVmData, {
    -                templateid : args.data.templateid
    -            });
    +            if (snapshotObjs) {
    +                $.extend(deployVmData, {
    +                    vmsnapshotid : selectedSnapshotObj.id
    +                });
    +            }
    +            else {
    +                $.extend(deployVmData, {
    +                    templateid : args.data.templateid
    +                });
    +            }
     
                 $.extend(deployVmData, {
                     hypervisor : selectedHypervisor
                 });
     
    -            if (args.$wizard.find('input[name=rootDiskSize]').parent().css('display')
!= 'none')  {
    -                if (args.$wizard.find('input[name=rootDiskSize]').val().length > 0)
{
    -                    $.extend(deployVmData, {
    -                        rootdisksize : args.$wizard.find('input[name=rootDiskSize]').val()
    -                    });
    -                }
    -            }
    +//            Currently it is not supporting in backend
    +//            if (args.$wizard.find('input[name=rootDiskSize]').parent().css('display')
!= 'none')  {
    --- End diff --
    
    please do not leave code commented in. this block should be deleted.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message