cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From remibergsma <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script
Date Sun, 06 Dec 2015 20:08:28 GMT
Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/1156#issuecomment-162342696
  
    @sanju1010 Thanks for the PR. Can you make it PEP8 compliant again please?
    
    Most tests seem to create the offering the test needs. Isn't that a better idea?
    
    I will run your version of the test. The previous one always succeeds for me, but I agree
with the hypervisor specific part. That should be generic.
    
    Will run it and report back.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message