cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wilderrodrigues <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9106 - As a Developer I want t...
Date Sun, 06 Dec 2015 12:40:12 GMT
Github user wilderrodrigues commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1179#discussion_r46769848
  
    --- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java ---
    @@ -841,24 +857,26 @@ public VirtualRouterProvider addElement(final Long nspId, final
Type providerTyp
     
         @Override
         public boolean applyPFRules(final Network network, final List<PortForwardingRule>
rules) throws ResourceUnavailableException {
    +        boolean result = false;
             if (canHandle(network, Service.PortForwarding)) {
                 final List<DomainRouterVO> routers = _routerDao.listByNetworkAndRole(network.getId(),
Role.VIRTUAL_ROUTER);
                 if (routers == null || routers.isEmpty()) {
                     s_logger.debug("Virtual router elemnt doesn't need to apply firewall
rules on the backend; virtual " + "router doesn't exist in the network " + network.getId());
    -                return true;
    +                result = true;
    --- End diff --
    
    Yes, it would. But I won't change because I don't agree with the approach of returning
true/false in several places. 
    
    1. A method that returns something should have only one point where it actually returns.
So those several returns is a bad practice. A way to make it not so bad is to assign the return
to a variable, so people looking at the code in the future won't miss a hidden "return true"
somewhere. I did not change all of it because in some places it requires a better refactor.
    2. If a method execution cannot proceed due to some condition, it should fail - exception.
A return false should be used when one wants to check is something is valid/exists or not.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message