cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wilderrodrigues <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9106 - As a Developer I want t...
Date Sun, 06 Dec 2015 12:32:20 GMT
Github user wilderrodrigues commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1179#discussion_r46769789
  
    --- Diff: plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java ---
    @@ -488,50 +494,54 @@ public boolean applyPFRules(final Network network, final List<PortForwardingRule
                 return true;
             }
     
    -        DataCenterVO dcVO = _dcDao.findById(network.getDataCenterId());
    -        NetworkTopology networkTopology = _networkTopologyContext.retrieveNetworkTopology(dcVO);
    -
    -        return networkTopology.applyFirewallRules(network, rules, routers);
    +        final DataCenterVO dcVO = _dcDao.findById(network.getDataCenterId());
    +        final NetworkTopology networkTopology = _networkTopologyContext.retrieveNetworkTopology(dcVO);
    +        for (final DomainRouterVO domainRouterVO : routers) {
    +            result = networkTopology.applyFirewallRules(network, rules, domainRouterVO);
    --- End diff --
    
    Yep... I know. That's what I said when you first mentioned it. I will change it now, but
we have to revisit many places in the Java side as well, and not only the classes I changed,
but the VpcManagerImpl.java, for instance.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message