cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wilderrodrigues <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9106 - As a Developer I want t...
Date Sun, 06 Dec 2015 01:37:52 GMT
Github user wilderrodrigues commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1179#discussion_r46765484
  
    --- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java ---
    @@ -751,13 +757,15 @@ public boolean savePassword(final Network network, final NicProfile
nic, final V
     
         @Override
         public boolean saveSSHKey(final Network network, final NicProfile nic, final VirtualMachineProfile
vm, final String sshPublicKey) throws ResourceUnavailableException {
    +        boolean result = false;
             if (!canHandle(network, null)) {
    -            return false;
    +            return result;
             }
             final List<DomainRouterVO> routers = _routerDao.listByNetworkAndRole(network.getId(),
Role.VIRTUAL_ROUTER);
             if (routers == null || routers.isEmpty()) {
                 s_logger.debug("Can't find virtual router element in network " + network.getId());
    -            return true;
    +            result = true;
    --- End diff --
    
    Because I do not want to return a literal. And the same for the other comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message