cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anshul1886 <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8845: Fixed list snapshots com...
Date Fri, 04 Dec 2015 11:31:20 GMT
Github user anshul1886 commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1166#discussion_r46673018
  
    --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
---
    @@ -459,12 +463,8 @@ public StrategyPriority canHandle(Snapshot snapshot, SnapshotOperation
op) {
                 storagePoolId = volumeVO.getPoolId();
             }
     
    -        if (SnapshotOperation.REVERT.equals(op)) {
    -            if (volumeVO != null && ImageFormat.QCOW2.equals(volumeVO.getFormat()))
    -                return StrategyPriority.DEFAULT;
    -            else
    -                return StrategyPriority.CANT_HANDLE;
    -        }
    +        if (SnapshotOperation.REVERT.equals(op) && volumeVO != null &&
ImageFormat.QCOW2.equals(volumeVO.getFormat()))
    --- End diff --
    
    Can be moved. I was not sure of whether KVM code is dependent on those side effects or
not so done like this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message