cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ProjectMoon <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Add support for not (re)starting server a...
Date Fri, 04 Dec 2015 11:18:59 GMT
Github user ProjectMoon commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1162#discussion_r46672120
  
    --- Diff: python/lib/cloudutils/serviceConfigServer.py ---
    @@ -135,9 +135,14 @@ def checkHostName():
                     self.syscfg.svo.disableService("tomcat6")
             except:
                 pass
    -            
    +
             self.syscfg.svo.stopService("cloudstack-management")
    -        if self.syscfg.svo.enableService("cloudstack-management"):
    -            return True
    +
    +        if self.syscfg.env.noStart == False:
    +            if self.syscfg.svo.enableService("cloudstack-management"):
    +                return True
    +            else:
    +                raise CloudRuntimeException("Failed to configure %s, please see the /var/log/cloudstack/management/setupManagement.log
for detail"%self.serviceName)
    --- End diff --
    
    The original message had the log message in the wrong place (I think it was pointing at
`/var/log/cloudstack-management/setupManagement.log`). I changed it to the right path on Linux
systems (for Ubuntu and friends). But probably the log path can be fixed as part of this commit
or in another one. But in order for the replace.properties stuff to work, there is an antrun
task I believe. Not sure it would currently process files in the directory that serviceConfigServer.py
is in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message